Jeanine Adkisson

Results 62 comments of Jeanine Adkisson

Verified still an issue on latest master - is there somewhere else where this was completed?

Currently symbol names in this syntax have to start with a-z: https://github.com/rouge-ruby/rouge/blob/1687d63cede01e9e1c108425e9987060ad85c79d/lib/rouge/lexers/ruby.rb#L86 Happy to switch this to a unicode property (`\p{...}`) if you can find documentation of what it's supposed...

The emoji does appear to work in the Ruby console though.

Also while I'm here this line should probably be non-greedy, even if it's protected by never matching unescaped `'`: https://github.com/rouge-ruby/rouge/blob/1687d63cede01e9e1c108425e9987060ad85c79d/lib/rouge/lexers/ruby.rb#L87

That is curious, the regexp really should be case-insensitive as well.

I'm a little nervous about significantly expanding the name rules without some assurance from Ruby folks about what it is exactly they intend to support. Does ruby have a spec...

Looks right to me. I didn't want to believe it but it looks like they *actually* implemented it this way: ``` ruby ; ruby -e 'p  :1' {: =>1} ```...

Looks like at least one other implementation agrees: https://github.com/lib-ruby-parser/lib-ruby-parser/blob/134edd54bac26dee604e27ea6d5537c20b265646/src/source/buffer.rs#L316

Thanks for the report! I think this was simply implemented incorrectly. This is a use case for recursive highlighting - scan for the docstring first and delegate. This is the...