Jean-Noël Avila

Results 148 comments of Jean-Noël Avila

These regexes are basically the same ones that I already pushed to git/git. They are applied during the conversion phase, not in live, and only on the quoted strings of...

Writing a parser turns out to be more involving than expected, mainly because the new parser must be resilient to formatting mistakes in the translations (particularly in Chinese) and manpages...

I've pushed an updated version with a parser. In case the parser fails, we just roll back to the basis code format.

@dscho Is this version better for you?

> @jnavila I've noticed we have a synopsis processor at https://github.com/git/git/blob/master/Documentation/asciidoctor-extensions.rb.in. Why did you chose to write it yourself? I rather not maintain 2 versions. In fact, I wrote both...

That would be great 😃. The parser cannot make a difference between the "git commit" part and the options, so they would have the same style ( bold red… for...

@To1ne In its current state, I think the PR is already able to correctly parse and format all the elements in back-quotes. There was a request to be able to...

I should rebase and address the comments from @dscho though.

> That said, can we deduplicate having a synopsis parser here and one in git/git.git ? This can be pushed also to git/git, but only for asciidoctor. For asciidoc, we...

The PR was reworked according to your remarks. I won't have much time to work on adding the code to deal with "git foo" formatting. Another span tag is added,...