jmxtrans Terminate jmxtrans when it runs into an exception

Address one common cause of uncaught exceptions, and also register an uncaught exception handler to cause jmxtrans to exit with a non-zero status rather than getting stuck in an inconsistent state.

Fixes #685.

Oct 10 '18 17:10 afn

:x: Build jmxtrans 265 failed (commit https://github.com/jmxtrans/jmxtrans/commit/b18b51f389 by @afn)

Oct 10 '18 17:10 AppVeyorBot

Looks good (minor comments inline). The travis failure seems like a transient (we have a /few/ tests that need /some/ cleaning).

Oct 10 '18 21:10 gehel

:+1: I've rebased this against ignore-hidden-files so this should merge without conflicts after #710 is merged.

Oct 10 '18 23:10 afn

Thanks for the quick review! Once #709, #710, and #712 have been merged, would you mind putting out a new release?

Oct 10 '18 23:10 afn

Thanks for the quick review! Once #709, #710, and #712 have been merged, would you mind putting out a new release?

Yep, I can do that. Ping me if I forget!

Oct 11 '18 19:10 gehel

Is this good to merge, or anything else that needs to be addressed?

Nov 01 '18 19:11 afn

This is an important PR, when will it be merged?

Nov 29 '18 10:11 ankitchiplunkar

Yea, we also have some issues with this problem in our infrastructure. Please make this part of the next release!

Nov 29 '18 11:11 jpzk

This PR is very close to https://github.com/jmxtrans/jmxtrans/pull/731 Does it fix the same problem?

Dec 03 '18 20:12 gquintana

Please merge this! We're running jmxtrans as a sidecar to our kafka & mirrormaker pods, but they often end up in "zombie mode" after exceptions like mentioned in this thread. I had to work around it by creating a liveness probe which monitors outgoing network traffic to detect when it stopped writing to our backend (influx). Messy at best!

Mar 29 '19 09:03 jeroenr

Is there anything that can be done to help get this over the finish line? We're running into this issue as well.

May 13 '19 17:05 coykitten