react-native-foldview icon indicating copy to clipboard operation
react-native-foldview copied to clipboard

Deprecated with the new react native version

Open vadermemo opened this issue 6 years ago • 8 comments

This amazing project is deprecated with the new react native version

vadermemo avatar Jul 10 '18 20:07 vadermemo

what do you mean by deprecated with the new react native version?

fabriziogiordano avatar Jul 10 '18 22:07 fabriziogiordano

Hi bro, try to create a new project with the react native last current version and you will see that have a lots of errors.

vadermemo avatar Jul 11 '18 17:07 vadermemo

same, image

MarianBe avatar Jul 20 '18 16:07 MarianBe

@jmurzy @fabriziogiordano @padampadam @vadermemo the problem is that NPM fetches a version (tagged as v1.1.1) that does NOT match the latest release on github - the specific issue is that the version that comes back from NPM relies on a removed import

import` React, {
  Component,
  PropTypes,
} from 'react';

I am not sure how this has happened, but basically if you can replicate it with the following steps:

npm init
npm i --save react-native-foldview

then go to node_modules/react-native-foldview/src/FoldView.js and you will see the file does NOT match latest on github and is totally broken on latest react version because of the PropTypes spin out.

or download the file that NPM is serving directly here - https://registry.npmjs.org/react-native-foldview/-/react-native-foldview-1.1.1.tgz

iamacup avatar Jul 23 '18 14:07 iamacup

If you do

npm i --save https://github.com/jmurzy/react-native-foldview

you end up with the correct version, it is really wierd.

iamacup avatar Jul 23 '18 14:07 iamacup

Just released master as v1.2.1. Can you check if that fixes your issue?

Also, we probably need to refactor things a little to make it compatible with the latest React Native. If anyone's willing to work on this, please feel free to send a pull request. Thanks.

jmurzy avatar Jul 28 '18 17:07 jmurzy

@jmurzy I am happy to help. Tho I am not an expert and I will really appreciate if you can give a couple of area you suggest to focus the efforts.

fabriziogiordano avatar Jul 31 '18 12:07 fabriziogiordano

It works well with these dependencies. "dependencies": { "lodash": "^4.17.11", "moment": "^2.24.0", "prop-types": "^15.7.2", "react": "16.8.3", "react-moment": "^0.8.4", "react-native": "0.59.2", "react-native-animatable": "^1.3.2", "react-native-elements": "^1.1.0", "react-native-foldview": "^1.2.1", "react-native-image-picker": "^0.28.1", "react-native-linear-gradient": "^2.5.4", "react-native-navigation": "^2.17.0", "react-native-splash-screen": "^3.2.0", "react-native-vector-icons": "^6.4.2" }

ghost avatar Apr 11 '19 07:04 ghost