finamp icon indicating copy to clipboard operation
finamp copied to clipboard

Switching tracks quickly causes app to crash

Open ProtoSparky opened this issue 1 year ago • 7 comments

Device: Samsung s21 Ultra (Exynos) SM-G998B/DS / Android 14 Finamp version: 0.9.12 Transcoding: yes / 320kbps Jellyfin version: 10.10.3 Audio tracks in library: 30k

Hi! Thanks for making such a beautiful and well polished app :3. For the past couple of months, I've experienced app crashes related to track switching, and it seems like the issue hasn't been documented yet.

To cause the crash, all you need to do is to play and then cancel playback of different songs in your library. It usually crashes after the 3rd or 4th time you switch songs, but it's rather inconsistent. The crashes occur regardless of how fast I switch tracks. I've sometimes gotten error messages saying "connection aborted" when switching songs, so those errors might be connected to the crashes.

Crashes occurred at timestamp 2024-12-06 11:43 in the log file provided

Video of steps to cause crash:

https://github.com/user-attachments/assets/fff3a6e9-4391-4500-a19b-90acc1b10f9d

Log file (trimmed): finamp-logs.txt

ProtoSparky avatar Dec 06 '24 11:12 ProtoSparky

Thanks for the report. I've seen a similar report, https://github.com/jmshrv/finamp/issues/866. Could you read through that and see if it could be the same bug, even if in the other issue there's no mention of a crash?

How did you install the beta? Did you upgrade from the stable version? If yes, do you know if you had any downloads before upgrading?
Also, would you mind re-installing the app to see if that resolves it?

Chaphasilor avatar Dec 11 '24 18:12 Chaphasilor

I've experienced the same issue as the user in 866 had, but I think this issue is different from theirs as mine does not recover from the fault and requires a full app shutdown before I can use the app again. It might be triggered by the same routines (codewise) but the resulting behavior is different.

I upgraded to the beta from within the Google play store but that was a really long time ago. I think I did migrate my data over to the beta app and didn't have any issues until now.

I cleared the data and reinstalled the app about 12h ago, and the issue still persists.

ProtoSparky avatar Dec 12 '24 12:12 ProtoSparky

Just wanted to chime in, I'm having the same issue. Have to force close the app in android before it becomes usable again.

S23 Ultra.

Aelzaire avatar Jan 09 '25 05:01 Aelzaire

I've added a change that will hopefully fix the issue, at least the freezing. I don't know why there is an error in the first place, there is no usable error message. But it's likely not an issue in Finamp directly, but in our audio library. A new beta update should arrive soon, and then you can try if the issue still persists :)

Chaphasilor avatar Feb 27 '25 17:02 Chaphasilor

Ty :3 I'll try that new update once it is available :)

ProtoSparky avatar Feb 28 '25 18:02 ProtoSparky

Unfortunately, this bug is still present on the latest beta. Tested on 2 different Android phones and also both Android 14 and 15.

Edit: Currently, for me it doesn't even require switching tracks fast. Switching tracks 1-2 times is sufficient to crash the app.

MB-Finski avatar Apr 14 '25 03:04 MB-Finski

With the latest beta released after the hackathon, the app no longer crashes for me. Sure, the playback still stops randomly and the play-bar at the bottom of the screen goes away but not having to restart the app constantly is already a really nice improvement!

MB-Finski avatar Apr 23 '25 07:04 MB-Finski