finamp icon indicating copy to clipboard operation
finamp copied to clipboard

FR: Update Downloads page collection UI when download completed, and more compact display option

Open ryanwwest opened this issue 9 months ago • 2 comments

This is just a cosmetic request. On the downloads page, let's say you've chosen to download a playlist with 5 songs and already downloaded them all. Then in another Jellyfin client you add another song to the playlist. To get this song downloaded I go to the Downloads page, expand that playlist item and see that only 5 songs show up. I then click the 'sync' button for that specific playlist and it gives some updates to downloading the new song, and eventually the download completes and is reflected by the number totals at the top left. However, the song list under the expanded album isn't changed to show the new song unless you collapse and expand the playlist item or reenter the page. This makes me unsure as a user if the download worked.

This also brings up another issue - even on my Galaxy Z Fold 3 I can only see 8-9 rows of songs on the screen at once. Many albums/playlist and most collections would be above this. Since you can't interact with the dropdown that shows the individual songs in a collection anyway, I wonder if they can optionally be made a lot more compact to help alleviate this issue. E.g., 'compact mode' button to hide the artwork, slightly decrease the font, reduce margin/padding, and try to fit all info on one line to perhaps 4x the amount of songs on a page. Another useful indicator could be at the top of each collection maybe have a count of number of songs successfully downloaded over the number of songs in that collection.

As a sidenote, it would be nice if additions (and maybe deletions..?) to playlists or other collections were automatically recognized and autodownloaded without this step, which might happen a lot when syncing a whole playlist or whole library. Perhaps this is already a feature though, and could be put in a different FR anyway.

ryanwwest avatar May 02 '24 14:05 ryanwwest

Finamp (at least the beta version) should automatically synchronize collections that are expected to change frequently (favorites, playlists, etc.) on startup. It could be that the app didn't shut down since you added the song to the playlist, and I think there's no way to synchronize the playlist immediately without user action if you added the song right before.
Eventually all major changes should be picked up by the download system though, and things should become consistent with online mode.

As for the design updates, a redesign of the downloads UI is definitely planned. We will probably get rid of the expandable list items, and either have a more nested approach, or a less detailed one. This could be some count of downloaded tracks over the size of the entire collection, like you suggested. There should be no need to manually confirm that a track was downloaded; if there was no error, everything should be downloaded successfully.

I was thinking about using the data fetched in online mode to immediately update offline mode data, e.g. if I view a downloaded playlist in online mode, it is compared to the offline version, and if it doesn't match up, a sync is triggered immediately. It seems possible, but @Komodo5197 probably has some additional insights. I wouldn't be surprised if they already implemented that and I just didn't notice xD

Chaphasilor avatar May 02 '24 16:05 Chaphasilor

Good to know, sounds like a lot of the issue I raised is already planned for, completed, or irrelevant. So feel free to close it whenever.

ryanwwest avatar May 02 '24 16:05 ryanwwest