jmshrv
Setting to hide download / delete button
I have the app set up for my kids to use, and I have the library downloaded for offline use. As they stumble around, it happens that they start deleting stuff. Could there be a setting to disable the download UI? I.e offline mode etc would still work, the app just wouldn't show the ability to download or delete downloaded files anywhere.
If there's interest, I should be able to look into opening a PR for it. I've flutted before.
Hey, thanks for the suggestion. I think we could definitely accept a PR that adds this (some kind of "lockdown" mode), but I don't think we'll have the time to add this ourselves anytime soon... 😅
How would you disable this mode? Should it be just a toggle buried in the settings, or require a pin to unlock or something? 🤔
And is there anything beyond downloading that should be hidden? Liking? Playlist editing?
In the open source tradition of scratching your own itch - for me it would be enough just to add a toggle in settings.
How would you disable this mode?
Hit the toggle again. This isn't about safety, or damaging something, just a minor bother, so I don't see a need to do anything intense. (So no PIN etc)
anything beyond downloading that should be hidden? Liking? Playlist editing?
That's an interesting idea. I have had some odd playlists pop up 😆 For starers I'd rather just lock down downloading/deleting, but maybe instead of calling it an "Edit download" toggle, I'd call it an "Enable child mode" toggle, with some text explaining what it does. That leaves the door open for others (or myself, IDK) to continue improving it in that vein.
Alright, that sounds good! Let me know if you need any help, and also give the contribution guidelines a quick read first to avoid some common pitfalls :)
It hasn't been bothering me recently. I'm still interested in this feature (and working on it), but it's been pushed to my backburner, unfortunately.
On Mon, Feb 12, 2024 at 1:18 PM Chaphasilor @.***> wrote:
Hey @yringler https://github.com/yringler any updates on this? 🤔
— Reply to this email directly, view it on GitHub https://github.com/jmshrv/finamp/issues/559#issuecomment-1939288739, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7B3KNQSHGB4NMRX4Y6VZ3YTJMGVAVCNFSM6AAAAABAZX3JN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZGI4DQNZTHE . You are receiving this because you were mentioned.Message ID: @.***>