finamp icon indicating copy to clipboard operation
finamp copied to clipboard

Weird Album Sorting on Artist Page

Open TinDefacto opened this issue 2 years ago • 5 comments

Hi there!

Some recent update -- I'm not sure which one -- sent the sorting of albums on an artist's page all out of wack. Now the order of an artist's releases may be (as in one case for me) 2021, 2016, 2019, 2013, 2020, 2013, 2011, 2014, 2019, 2016, 2022. It's not even alphabetical, so I'm really confused! I really appreciated the previous chronological order, and I don't see this issue being raised elsewhere, so I figured I'd point it out.

Thanks again for all the work y'all do. :)

TinDefacto avatar Nov 23 '23 06:11 TinDefacto

That might've been https://github.com/jmshrv/finamp/pull/448 or #493

Could you check the full metadata in Jellyfin to see what the PremiereDate of these albums is, compared to the production year?

Chaphasilor avatar Nov 23 '23 08:11 Chaphasilor

Oh, interesting -- thanks for the response! I hadn't seen #448, and that looks most likely to be the culprit, but when I look at the metadata on Jellyfin, literally only one of the albums has a release date, and that's the 2022 one (which appears last). So I'm not sure what's going on?

On Thu, Nov 23, 2023 at 3:03 AM Chaphasilor @.***> wrote:

That might've been #448 https://github.com/jmshrv/finamp/pull/448 or #493 https://github.com/jmshrv/finamp/pull/493

Could you check the full metadata in Jellyfin to see what the PremiereDate of these albums is, compared to the production year?

— Reply to this email directly, view it on GitHub https://github.com/jmshrv/finamp/issues/536#issuecomment-1823946587, or unsubscribe https://github.com/notifications/unsubscribe-auth/APV3DXJKVRC2ZBF7OGLVDGDYF37MPAVCNFSM6AAAAAA7XI5VB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRTHE2DMNJYG4 . You are receiving this because you authored the thread.Message ID: @.***>

TinDefacto avatar Nov 23 '23 08:11 TinDefacto

And doing a quick survey of other artists, it seems like it's correctly sorting albums that have release dates filled in -- but for those that only have a year, I can't find rhyme or reason to the order it decides on.

On Thu, Nov 23, 2023 at 3:34 AM Sebastian J. Garza < @.***> wrote:

Oh, interesting -- thanks for the response! I hadn't seen #448, and that looks most likely to be the culprit, but when I look at the metadata on Jellyfin, literally only one of the albums has a release date, and that's the 2022 one (which appears last). So I'm not sure what's going on?

On Thu, Nov 23, 2023 at 3:03 AM Chaphasilor @.***> wrote:

That might've been #448 https://github.com/jmshrv/finamp/pull/448 or #493 https://github.com/jmshrv/finamp/pull/493

Could you check the full metadata in Jellyfin to see what the PremiereDate of these albums is, compared to the production year?

— Reply to this email directly, view it on GitHub https://github.com/jmshrv/finamp/issues/536#issuecomment-1823946587, or unsubscribe https://github.com/notifications/unsubscribe-auth/APV3DXJKVRC2ZBF7OGLVDGDYF37MPAVCNFSM6AAAAAA7XI5VB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRTHE2DMNJYG4 . You are receiving this because you authored the thread.Message ID: @.***>

TinDefacto avatar Nov 23 '23 08:11 TinDefacto

If there is no release date provided, the order is most likely just random, as you are observing. We should fall back to sorting by production year and then name I think

Chaphasilor avatar Nov 23 '23 11:11 Chaphasilor

Yes, I think that would make the most sense! Preferably by taking any blank release dates to be YEAR-01-01, so it gets sorted in with the dates ones, if that makes sense.

On Thu, Nov 23, 2023 at 6:34 AM Chaphasilor @.***> wrote:

If there is no release date provided, the order is most likely just random, as you are observing. We should fall back to sorting by production year and then name I think

— Reply to this email directly, view it on GitHub https://github.com/jmshrv/finamp/issues/536#issuecomment-1824271465, or unsubscribe https://github.com/notifications/unsubscribe-auth/APV3DXMYVPGF3JI7PTCS7HTYF4YF7AVCNFSM6AAAAAA7XI5VB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRUGI3TCNBWGU . You are receiving this because you authored the thread.Message ID: @.***>

TinDefacto avatar Nov 23 '23 11:11 TinDefacto