finamp
finamp copied to clipboard
jmshrv
Recently played songs through Finamp do not show up in the server (eventually)
Hello,
A bit of an odd one here (based on my understanding of how this works).
While playing songs through Finamp, eventually the songs I play stop being reported as "played" in the server. I verify this by logging into the webgui on the sever, going to Music -> Songs, then ordering the songs by Last Plad descending.
This isn't 100% a problem. The first few songs I play seem to show up here but eventually the songs will stop being reported as played. The songs are NOT downloaded (I recently deleted my downloaded songs just to be sure).
The only thing that might be a bit wonky is that I access my songs over a VPN but if I am playing my songs that means I have access to the server (which is streaming the songs).
Any thoughts? Is there any chance my Jellyfin server is telling the app to directly play the file from my NAS and not through jellyfin (which should note if something is being played)?
Was able to reproduce this. App says "streaming direct" so I should be getting the data from Jellyfin. I vaguely figured out it has to do with pausing/stopping play, turning off my screen, turning my screen back on, then trying to play.
Reminder - this is behind a VPN. Not sure if iOS is doing something to the VPN connection and possible some caching of the song on Finamp?
Obviously this might not be a Finamp issue but I figured I should at least bring it up for a discussion.
Playback reporting is a bit flaky, there's a PR that should fix one main issue (#200), and there are a few more issues about discussing how to improve it further (#421)
I looked at this recently and I think we're simply not marking tracks as "played" at all. It seems to be separate from playback reporting, but should be fairly easy to implement
Here's the relevant API endpoint: https://api.jellyfin.org/openapi/api.html#tag/Playstate/operation/MarkPlayedItem
This should be called whenever _jellyfinApiHelper.stopPlaybackProgress() is called within the app and the current track has been played for more than ~15s
playback reporting is handled differently now. if we would call that endpoint, each track would be marked as played twice, which we don't want.
@cmsimike could you try out the beta version so see if this is still an issue there?
Sorry - been listening to it over the past week and at least it isn't as easy to replicate it. I remember this happened a few songs into an album, but I have listened to a few albums so far and they all seem to be accounted for.
Thank you!