finamp
finamp copied to clipboard
jmshrv
Bug - Long song titles are cut off in player view
In the player view, song titles that are too big to fit in the song title text box are cut off, so you can't read the whole title.
example:
Notice how the song's title text fades out on the right. There is currently no way to know what the full title of the song is in this view.
a soultion
A way to solve this would be to add marquee to the text so it scrolls from right to left to reveal the whole title.
A marquee would be nice, I'll implement it for names. In the redesign, album names are pretty small so it shouldn't be an issue.
Hello! I also think a marquee would be nice for long names. The following video shows a possible solution.
https://github.com/jmshrv/finamp/assets/47425957/3f421df7-d8a6-4803-acca-eb6d7b881d85
Here is the version used in the video https://github.com/Ivanf1/finamp/tree/marquee
It would be nice if the marquee could be a fallback-solution that is only used if the title really doesn't fit. Because the marquee is always a single line, and by default the title is shown over two lines, increasing how much info can be shown at once.
Hi! Yes, I agree, that would be a better solution. I updated the version at https://github.com/Ivanf1/finamp/tree/marquee to implement this. Now the marquee is used only if the song name would need more than two lines to be displayed fully.
Let me know what you think!
@Ivanf1 sorry for missing this! That change looks really nice, and I'd be happy to accept a PR for this!
There's also #754 which does something similar, but for the track menu. But I think your change is still a nice addition!