finamp icon indicating copy to clipboard operation
finamp copied to clipboard

Album covers are cropped on very slim/tall screens

Open Maxr1998 opened this issue 2 years ago • 2 comments

On screens with a high aspect ratio that are tall but slim (like the cover screen on the Samsung Z Fold 4), covers are cropped on the sides.

Instead of cropping them, they should be fit inside the screen dimensions, with some additional padding, e.g. at the top to visually center the cover.

Screenshot_20220907_142329.png

Maxr1998 avatar Sep 07 '22 12:09 Maxr1998

This will eventually be fixed by #220, not sure if @jmshrv wants to add a temporary fix for this...

Chaphasilor avatar Sep 07 '22 20:09 Chaphasilor

I'll look in to this :)

jmshrv avatar Sep 07 '22 20:09 jmshrv

@Maxr1998 can you try it on the latest redesign branch? I made some changes to hopefully better support different screen sizes with the redesign :)

Chaphasilor avatar Jan 28 '24 20:01 Chaphasilor

Seems pretty good! During my quick test I noticed the album screen is a little odd now, but that's another issue.

Screenshots

Screenshot_20240208_234442.png Screenshot_20240208_234436.png

Maxr1998 avatar Feb 08 '24 22:02 Maxr1998

Awesome, thanks. Yeah that screen will be redesigned anyway so I won't dive into cosmetic fixes for the time being ^^

Chaphasilor avatar Feb 08 '24 23:02 Chaphasilor

Understood. A popup menu or something might be preferable anyway so that it's not so crowded.

Anyways, sorry for taking so long to reply and thanks for fixing the album art issue. The redesign branch already looks really nice, great work!

Maxr1998 avatar Feb 08 '24 23:02 Maxr1998