finamp icon indicating copy to clipboard operation
finamp copied to clipboard

[Feature]Localization?

Open charleypeng opened this issue 1 year ago • 16 comments

I can help with this

charleypeng avatar Aug 03 '22 02:08 charleypeng

I am willing to prepare a Polish translation of the application.

ChrisB85 avatar Aug 08 '22 19:08 ChrisB85

I'll set up a Weblate project this week :)

jmshrv avatar Aug 09 '22 07:08 jmshrv

cool

charleypeng avatar Aug 09 '22 07:08 charleypeng

Weblate has been set up at https://hosted.weblate.org/projects/finamp/ :)

Feel free to ask if you need more context for strings

jmshrv avatar Aug 18 '22 10:08 jmshrv

I'm not familiar with Weblate so I'm not sure if that's on you as the translation "admin", but could you look into enabling triple translations for phrases where a number might be plural? Example: https://weblate.nheko.im/translate/nheko/nheko-master/pl/?q=cz%C5%82onkowie&sort_by=-priority%2Cposition&offset=2, when the number ends on 2, 3 or 4 the word following it in Polish sometimes has different form than if the number ends on 5-0.

rom4nik avatar Aug 22 '22 21:08 rom4nik

Using plurals is documented here: https://docs.google.com/document/d/10e0saTfAv32OZLRmONy866vnaw0I2jwL8zukykpgWBc/edit#heading=h.yfh1gyd78g7g

In theory, you should be able to type a string like in the document. There are a few strings in Finamp that use this plural handling in English, such as downloadedMissingImages.

jmshrv avatar Aug 22 '22 22:08 jmshrv

image

do I ignore those things in the curly brackets and just write the translation?

MrPotatoBobx avatar Aug 24 '22 08:08 MrPotatoBobx

The curly braces are placeholders where information is inserted. You'll need to insert them into the new translation wherever they fit the sentence.

jmshrv avatar Aug 24 '22 08:08 jmshrv

Got it, thanks.

MrPotatoBobx avatar Aug 24 '22 08:08 MrPotatoBobx

image is this "to list" (verb) or "a list" (noun)?

MrPotatoBobx avatar Aug 25 '22 20:08 MrPotatoBobx

It's used as a noun to reference a list layout (same goes for "grid")

jmshrv avatar Aug 25 '22 23:08 jmshrv

ِArabic has fully been translated. If you are an Arabic speaker reading this, I urge you to double check and look for errors in grammar, or places where better words could be used.

MrPotatoBobx avatar Aug 26 '22 04:08 MrPotatoBobx

Heylow, for french, I think we'd need some context for these:

  1. premiereDate - Premiere Date is it the "Release date" of a movie (eg. as shown on a movie's Wikipedia pages) ? (ie. "date de sortie")
  2. revenue - Revenue is the "Box office" number (eg. shown on a movie's Wikipedia pages) ?
  3. invalidNumber - Invalid Number is it "a number" like in "You picked an invalid lottery number, the winning one was 5" (ie. "numéro")
    or is it "an amount" like in "The number of items is invalid ; cannot be that high" (ie. "nombre")

alaincao avatar Aug 27 '22 08:08 alaincao

  1. Premiere date is the release of a film
  2. Revenue is like the amount of money a film gets from the box office
  3. invalidNumber is used when the user gives an invalid number to the sleep timer dialog, such as if they somehow got text into that input.

(note that Revenue isn't exposed in Finamp, it's just there because its part of the Jellyfin API. Premiere date can be found in the sort options)

jmshrv avatar Aug 28 '22 01:08 jmshrv

@jmshrv The main component should not be marked as a glossary. Doing that makes translating it harder.

comradekingu avatar Sep 08 '22 18:09 comradekingu

Fixed :)

jmshrv avatar Sep 08 '22 21:09 jmshrv

We are moving discussion for localization/translations to GitHub's "Discussion" section, which is better suited for this. I'll go ahead and close this issue.
If you subscribed to this issue to the past and want to continue to receive updates about translation issues, you could subscribe to updates about discussions: image Sadly, filtering specific topics isn't possible (although I don't think this is a problem for anyone)

Chaphasilor avatar Oct 22 '23 14:10 Chaphasilor