finamp icon indicating copy to clipboard operation
finamp copied to clipboard

[Feature Request] Automatic switch to Offline Mode when disconnected from Wi-Fi

Open rigrig opened this issue 2 years ago • 5 comments

It would be nice if Finamp could automatically switch to Offline Mode when disconnecting from Wi-Fi, to prevent mobile data usage. (And back to Online when reconnecting)

rigrig avatar Apr 10 '22 11:04 rigrig

This would be nice to have, I'd have to think about how to handle whether or not to automatically switch though (as someone may want to manually enable offline mode on WiFi, or vice-versa

jmshrv avatar Apr 10 '22 16:04 jmshrv

Ideally (and I'm pretty sure it works this way already but I'm not 100% certain) if the song is already downloaded it should play the downloaded copy rather than playing it from the server.

That said I think having this as an option users can toggle on to save bandwidth is a fantastic idea.

drazil100 avatar Apr 10 '22 22:04 drazil100

Ideally (and I'm pretty sure it works this way already but I'm not 100% certain) if the song is already downloaded it should play the downloaded copy rather than playing it from the server.

Yeah, this is the default. You can see whether or not the song is streaming or playing from a download on the bottom left of the player screen.

jmshrv avatar Apr 10 '22 22:04 jmshrv

Does the app do some kind of caching when a music has been played like Plexamp do ? That's maybe how they handle this ?

Ge082 avatar Apr 11 '22 23:04 Ge082

how to handle whether or not to automatically switch

I don't know about iOS, but IIRC on Android at least you can a) request the current network state b) get an event when the network changes

What I would like it to do:

  • Add a setting to enable Automatic Offline Mode
  • If the setting is enabled:
  • When starting up, or the network state changes:
    • if the network is connected and metered: go offline
    • if the network is connected and unmetered: go online
    • otherwise: do nothing.

That way users can still turn it on/off manually, and (briefly) losing connectivity won't cause surprises.

(I guess later on we might also like a setting for a "Home" network)

rigrig avatar Apr 12 '22 08:04 rigrig