finamp icon indicating copy to clipboard operation
finamp copied to clipboard

Album playback not possible when not all songs of album completely downloaded

Open arvidortwig opened this issue 3 years ago • 2 comments

Plattform: Android 11 and Finamp 0.5.1

Current behaviour: I have experienced that it is not possible to play a single song of a downloaded album (in offline mode) if not all of the songs are properly downloaded e.g. one is missing.

Expected behaviour: It should be possible to play all already downloaded songs even if one is missing.

arvidortwig avatar Jan 28 '22 08:01 arvidortwig

Are you seeing an error like this?

https://github.com/UnicornsOnLSD/finamp/blob/3668e7d14fd93ac251371aa3c1d8f040b0cca9bb/lib/services/AudioServiceHelper.dart#L200

I think the current behaviour is just to fail entirely if a song is missing, but I could change it to just skip non-downloaded songs.

jmshrv avatar Feb 11 '22 12:02 jmshrv

It should definitely skip. If you press any single song on album view in offline mode, when one of the others isn't downloaded nothing happens at all.

joestrong avatar Feb 17 '22 11:02 joestrong