jmshrv
Some OfflineMode Tweaks
Added Info label to display the current state (translations to be added soon:tm:)
Naturally the label also shows this
Made that the override can override both offline mode to be enabled and disabled instead of just enabled as before
Changed the icon of Offline Mode to show when the automation is reevaluating (since the 7 second delay exists)
Removed the LifeCycle from AutoOffline.startWatching since we are unsure why I added this in the first place haha
And Tweaked the AutoOffline code a bit in terms of readability (shouldnt introduce functional changes)
Nice!
I think we can find some less technical wording, so instead of "automation active", maybe "Will switch automatically" or something like that? Open for suggestions. Same for "Override active", how about "Automatic switching paused"?
I'm also wondering, how do I re-enable the automation? If offline mode was turned on automatically and I turn it off, do I then have to turn it back on for the automation to kick in again? Do I have to have no connectivity when doing this, so that it counts as a valid state?
Maybe there should just be a button when the override is active, which allows disabling the override?
Oh and unrelated, but it looks like you have some kind of gradient effect going on? Which platform is that screenshot from, Arch?
I think we can find some less technical wording
Understandable, though wouldnt that introduce the possibility of line wrapping on mobile? That would look kinda very bad
I'm also wondering, how do I re-enable the automation
Its literally a toggle. When you click the switch you start the override, when you click again override is stopped and automation takes over again
Oh and unrelated, but it looks like you have some kind of gradient effect going on
Hyprland baby. thats just my background :)
line wrapping on mobile? That would look kinda very bad
I don't think wrapping is an issue. The text should be small and right beneath though
Its literally a toggle. When you click the switch you start the override, when you click again override is stopped and automation takes over again
So it's not possible to re-enable the automation without changing the state? i.e. if I manually enabled offline mode before Finamp figured it out itself, but would like Finamp to switch back into online mode automatically later on, I can't do that? Because only toggling offline mode off will re-enable the animation, and then it probably won't re-evaluate the network state?
I think we should rename "Prefer Home Network" to "Prefer Local Address", and "Home Network Address" to "Local Address". Would you mind throwing that into this PR as well?
I honestly don't think it looks bad. But it also isn't obvious that it's tappable. I'll see what I can do tomorrow (today?)!
tomorrow :tm:
From the technical side this is working though, right? My plan is to deal with any remaining UI issues tomorrow and then merge this :)
my testing concluded that everything works as it should translations still need to be added though
Just tried it out and can confirm that it's working. The logic for showing the different icons was slightly broken, but I've fixed that and added more granular options.
I really am a fan of the "button" that's just a title and description, that's really clear. I just highlighted it a bit more to emphasize that it's clickable, and updated the wording to make it (hopefully) clearer and shorter.
Take a look!