finamp
finamp copied to clipboard
jmshrv
Artist Tab Margin to small
Hi, First of thank you for creating this awesome app it really has simplified my music streaming a lot. One small thing however bugs me: in the artist Tab there is no margin between the different artists, same thing with the genres tab. I'm not sure if this is a design choice but I think it looks a little odd.
I tested this on two different Android phones and both showed the same results.
Artists tab:
Yeah it annoys me too. I tried to add the number of albums below the artist name but Jellyfin wasn't giving it to me for some reason. I'll probably try again at some point.
It's yours :)
Just open a pull request whenever you're ready, and let us know if you need any help!
can you please help in setup for this project for windows? docker or manual anything will work
@Mandeep56Singh of course! Generally the steps are as follows:
- Install Flutter & set up your preferred editor (https://docs.flutter.dev/get-started/install)
- Follow the guide until the chapter "Test Drive" (inclusive)
- Make sure Git is installed. If not, search online on how to install it
- Clone the Finamp repository into a directory like
DocumentsorCode. The command isgit clone https://github.com/jmshrv/finamp - Open the newly created
finampfolder with your editor (i.e. VS Code) - If you editor is configured correctly, it should detect Finamp's Flutter project automatically
- Attach your phone via USB (and allow USB debugging)
- "Build" the project, this should automatically generate all files and launch the Finamp app on your phone
- You might have to uninstall Finamp from your phone first, because your computer will use a different unique signature than @jmshrv's
That should be it, but maybe @jmshrv can add some other things I might have missed :)
@Chaphasilor sorry for late response , I having problem passing the first screen , how to set server , username and password ? Really sorry for this dumb question , actually i have not use any jellyphin service before.
Do you have a Jellyfin server? You'd use the URL you use to access it, and your username/password.
Ah, well you could use the demo server by doing:
Server URL: https://demo.jellyfin.org/stable
Username: demo
And leave password blank
Note that the demo server gets wiped every hour, so you'll have to sign in again each hour.
Just wondering, if you don't have a Jellyfin server, what's made you want to contribute to Finamp?
I have solved the artist sections
but when I try to give padding to genre section , the albums sections padding increases
Yeah that's because the AlbumListTile is also used for genres. You could copy into a separate GenreListTile and use that instead?
https://github.com/jmshrv/finamp/blob/main/lib/components/MusicScreen/music_screen_tab_view.dart#L378-L391
Yeah that's because the
AlbumListTileis also used for genres. You could copy into a separateGenreListTileand use that instead?https://github.com/jmshrv/finamp/blob/main/lib/components/MusicScreen/music_screen_tab_view.dart#L378-L391
can you help me how to do it ? I have copied all content of AlbumListTile into GenreListTile but i am unable to connect it to genre tabs
Sorry, didn't see your response. You need to rename all the classes that you copied into the new file, so that it says
class GenreListTile instead of class AlbumListTile, and so on. Then you can import the new file within the genre list, by adding an import at the top of the file. There should be an import for AlbumListTile already, just duplicate it and change the file path :)
@kjboa this has been fixed as part of the redesign beta (maybe it's also in the stable version already?). You can check it out here: https://github.com/jmshrv/finamp/releases/tag/0.9.2-beta
I'll close this issue for now since it should be resolved.