cron-utils icon indicating copy to clipboard operation
cron-utils copied to clipboard

Cannot map day of week (5#1)

Open alexey-anufriev opened this issue 2 years ago • 2 comments

It is not possible to perform the following mapping:

CronDefinition cronDefinition = CronDefinitionBuilder.instanceDefinitionFor(CronType.SPRING);
CronParser cronParser = new CronParser(cronDefinition);
Cron cron = cronParser.parse("0 0 0 ? * 5#1");
CronMapper mapper = CronMapper.fromSpringToQuartz();
Cron quartzCron = mapper.map(cron);

Execution leads to the following exception:

java.lang.IllegalArgumentException: value missing for a#b cron expression

	at com.cronutils.utils.Preconditions.checkArgument(Preconditions.java:110)
	at com.cronutils.model.field.expression.On.<init>(On.java:43)
	at com.cronutils.mapper.CronMapper$1.visit(CronMapper.java:294)
	at com.cronutils.model.field.expression.On.accept(On.java:70)
	at com.cronutils.mapper.CronMapper.lambda$dayOfWeekMapping$5(CronMapper.java:288)
	at com.cronutils.mapper.CronMapper.map(CronMapper.java:88)

alexey-anufriev avatar Jul 21 '23 11:07 alexey-anufriev

@alexey-anufriev may we ask you for a PR with the corresponding test? Thanks!

jmrozanec avatar Jul 21 '23 14:07 jmrozanec

Sure, https://github.com/jmrozanec/cron-utils/pull/606

alexey-anufriev avatar Jul 21 '23 14:07 alexey-anufriev