MyHome Endpoint for booking an amenity

⚠️ Is your feature request related to a problem? Please describe

Endpoint for booking an amenity

💡 Describe the solution you'd like

POST /amenities/{amenityId}/bookings
Update postman collection

Task Relationship

Subtask of: jmprathab/MyHome#94

Aug 08 '20 09:08 jmprathab

@jmprathab Hello, I'm new in open source, can I take this task?

Sep 09 '20 17:09 zhupanovdm

@zhupanovdm Sure. Request you to comment on your approach before implementing.

Sep 14 '20 13:09 jmprathab

@zhupanovdm Any update from you?

Oct 02 '20 16:10 mslowiak

Hi. Sorry for silence. There was a lack of spare time. But now I'm in.

Oct 03 '20 17:10 zhupanovdm

@zhupanovdm How it is going?

Oct 10 '20 09:10 mslowiak

It has been 9 days since last update, task is still up for grabs :)

Oct 12 '20 20:10 mslowiak

Shall I take this up?

Oct 16 '20 17:10 tomsajuk

Hi @jmprathab had some queries regarding the issue. Posting it below:

Should a user be able to book an amenity for another user? (neighbours maybe)
Any restrictions on the number of bookings and people at a particular time-slot? (There would be rush during weekends)
Can assume that the user can only book an amenity available in his community? (Would be throwing error if outside the community, so what error should I throw?)
Whats the purpose of the 'price' attribute in the Amenity domain? Should the user be paying at the time of booking or its a membership fee?

If you could answer these queries would help a lot in the implementation. :) If you add your thinking that would also be good.

Oct 18 '20 13:10 tomsajuk

Hi @jmprathab had some queries regarding the issue. Posting it below:

Should a user be able to book an amenity for another user? (neighbours maybe)

Any restrictions on the number of bookings and people at a particular time-slot? (There would be rush during weekends)

Can assume that the user can only book an amenity available in his community? (Would be throwing error if outside the community, so what error should I throw?)

Whats the purpose of the 'price' attribute in the Amenity domain? Should the user be paying at the time of booking or its a membership fee?

If you could answer these queries would help a lot in the implementation. :) If you add your thinking that would also be good.

Great thoughts BTW.

Let's not do this.
Yes. Booking overlap should be restricted.
HTTP 403 can be returned in case. Note: Implementation has to use AuthorizationFilter rather than having the logic in the controller. master has similar implementations already.
User is not expected to pay for the amenity while booking. The idea is, CommunityAdmin might be able to generate a payment for a particular user for using an amenity.

Oct 19 '20 14:10 jmprathab

@tomsajuk Are you working into this task? If not, can I please get it? Thanks 👍