Joe Mooring comments

Results 602 comments of


                                            Joe Mooring

tpl/tplimpl: Add error handling to embedded link/image render hooks

I've changed the issue title. We can expand on this if the project lead accepts the proposal.

tpl/tplimpl: Add error handling to embedded link/image render hooks

General comments... 1. Theme and module authors often duplicate configurations under params (e.g., for custom TOC, hooks, and pagination). This isn't ideal, but it's necessary because we intentionally don't expose...

Markdown code block within fully rendered shortcode should not be parsed for HTML syntax errors

Confirmed. This has been an issue since at least v0.54.0 (I didn't test anything earlier). Simplied example... layouts/shortcodes/foo.html ```` ``` = 4 spaces) instead of with fences.

tpl: Add missing functions to init files

I'm also going to alphabetize the entries, so the change set will be a bit larger.

tpl: Add missing functions to init files

I think we can remove this: ```go ns.AddMethodMapping(ctx.DoDefer, []string{"doDefer"}, [][2]string{}, ) ``` The function is marked for internal use, and we have not documented it anywhere.

tpl: Add missing functions to init files

> I assume a test will fail It does. Thanks.

Update openapi3.Unmarshal docs

@bep Prior to the changes in https://github.com/gohugoio/hugo/pull/14197 you could use a remote resource with `openapi3.Unmarshal`: ```go-html-template {{ with try (resources.GetRemote $url) }} {{ with .Err }} {{ errorf "%s" ....

Update openapi3.Unmarshal docs

My understanding/experience with OpenAPI documents is nil. I'll use the example you provided above, but I don't understand why you would need to add an authorization header once you already...

Update openapi3.Unmarshal docs

Gotcha. Thanks for the explanation. This example (per yours above)... ```text {{ $api := "" }} {{ $url := "https://petstore.swagger.io/v2/swagger.json" }} {{ $opts := dict "key" (dict "Authorization" "Bearer abcd")...

Update openapi3.Unmarshal docs

Order of args... should have seen that.