vifun icon indicating copy to clipboard operation
vifun copied to clipboard

fix permissions to run on binary distrib (linux/osx)

Open jmlucjav opened this issue 12 years ago • 11 comments

jmlucjav avatar Feb 25 '13 21:02 jmlucjav

This also goes for griffonw script

janhoy avatar Feb 26 '13 13:02 janhoy

Binary distribution does not contain any griffonw, so I suppose you mean source distrib. And using source one, I think you should not call bundled ./griffonw, but /bin/griffon from the required griffon-1.1.0 package that should be already installed.

jmlucjav avatar Feb 26 '13 17:02 jmlucjav

Ok. chmod 755 in the source distro then. griffonw seems to work equally well as manually installing griffon first, so it's a faster solution.

janhoy avatar Feb 26 '13 19:02 janhoy

FYI griffonw allows you to run run Griffon apps without having a Griffon distribution installed in your system before hand. This is a feature we copied from Gradle, see http://griffon.codehaus.org/guide/latest/guide/theCommandLine.html#theGriffonWrapper for reference.

aalmiray avatar Feb 27 '13 11:02 aalmiray

thanks, I didn't know that until Jan mentioned it. I'll update the readme to reflect that. Any comment on the issue itself? Should premissions be on already on the zipped dist or is up to the user to do it after the installation?

jmlucjav avatar Feb 27 '13 13:02 jmlucjav

According to line 328 https://github.com/griffon/griffon/blob/master/subprojects/griffon-scripts/src/main/groovy/Package.groovy we already set permissions on non *.bat files. Is this not working for your package?

aalmiray avatar Feb 27 '13 13:02 aalmiray

No

Clean Git checkout:

-rw-r--r--   1 janhoy  staff  5050 Feb 27 14:34 griffonw

should be

-rwxr-xr-x   1 janhoy  staff  5050 Feb 27 14:34 griffonw

janhoy avatar Feb 27 '13 13:02 janhoy

Note that I package the dist on windows...not sure if it's relevant...

jmlucjav avatar Feb 27 '13 13:02 jmlucjav

I think we have two problems here:

  1. griffon distro does not assign executable permissions to griffonw. Filed and Fixed http://jira.codehaus.org/browse/GRIFFON-610
  2. zip package does not assign executable permissions to bin/vifun

I think this issue is about the second item, is it not?

aalmiray avatar Feb 27 '13 13:02 aalmiray

yes, this was about the second item. Jan just added the info about griffonw also lacking permissions, as both are pretty similar

jmlucjav avatar Feb 27 '13 19:02 jmlucjav

OK, so packing on Windows is still an issue as the Gant script does not apply executable permissions to files found under 'bin' ?

aalmiray avatar Feb 28 '13 08:02 aalmiray