Jonathan Lange
Jonathan Lange
I discovered this last night while trying to build good tests for https://github.com/jml/graphql-api/pull/92. I tried to change our example schema by: * making dog's owner a `Sentient` * giving humans...
`API` and `Value` have submodules, but it's not clear what their relation is to the main, or how users are expected to import them. My vote is for everything to...
Neither @jml nor @teh like `Result` in Resolver very much. jml thinks we should have something like a writer monad, since error messages are more-or-less orthogonal to the output. teh...
We should have a type class for formatting values for clients, implement that for things that we're validating etc., and then use it when generating error messages. `Show` should just...
GraphQL says lists are homogeneous. All elements should be the same type. Our type is currently: ```haskell newtype List = List [Value] deriving (Eq, Ord, Show) ``` We could change...
In #42, @teh and I both [agreed](https://github.com/jml/graphql-api/pull/42#discussion_r93762146) that we should ideally _not_ be checking for schema validity while we are resolving values. The difficulty is that we need to construct...
We have some support for interfaces, but it's not at all clear how you'd implement a handler for something like: ```graphql type Query { dog: Dog } type Dog {...
We currently have absolutely no support for this. We should have some. Specifically for `@skip` and `@include`
According to https://github.com/jml/graphql-api/pull/92#discussion_r98338377, and because it's not in `Internal`, `HasResolver` is a public API. However, the module has no doc comment, and `HasResolver` has no documentation. If we intend people...
If we keep the line & column when we parse documents, we can give better error messages: not just for parsing failures, but also for validation errors (_this_ name is...