jmix-docs icon indicating copy to clipboard operation
jmix-docs copied to clipboard

Improve PasswordField doc

Open glebfox opened this issue 10 months ago • 0 comments

Existing page: https://docs.jmix.io/jmix/flow-ui/vc/components/passwordField.html

  1. passwordField.getValue().isEmpty() == false can be simplified to !passwordField.getValue().isEmpty().

  2. Value description says:

If the value cannot be parsed to String, the default conversion error message appears.

Previously doc says:

The input for passwordField can only be of type String.

~Question: in what cases the value cannot be parsed to String?~ String can be converted to String in any cases.

  1. Handlers.

    1. Missing statusChangeHandler
    2. ChangeEvent and InvalidChangeEvent no longer valid
  2. Validator code example: String.valueOf(value) is redundant, value is already a String.

  3. Elements. Missing prefix and suffix elements.

  4. Add revealButtonVisible attribute: wait for https://github.com/jmix-framework/jmix/issues/3206

  5. Add css, ariaLabel, ariaLabelBy, focusShortcut common attributes

  6. Remove requiredIndicatorVisible, invalid

glebfox avatar Apr 27 '24 08:04 glebfox