Jovan Mitrevski

Results 133 comments of Jovan Mitrevski

Can people look at this? It's a minor change that has been sitting for a while.

I remember the model parsing sometimes giving extra warnings in the past due to some convoluted logic but working in the past, so I wanted to make sure that wasn't...

The tests fail with: ``` FAILED test_pytorch_api.py::test_skipped_layers[io_parallel-Vivado] - TypeError: config_from_pytorch_model() got an unexpected keyword argument 'inputs_channel_last' FAILED test_pytorch_api.py::test_skipped_layers[io_parallel-Quartus] - TypeError: config_from_pytorch_model() got an unexpected keyword argument 'inputs_channel_last' FAILED test_pytorch_api.py::test_skipped_layers[io_stream-Vivado] -...

Sorry for the delay, but what is the status of this? It looks to me like maybe I can approve and merge it.

I wonder if this is part of the inferring of precisions that's in the works: #855. Let me try to update #855 (by making pull requests to it) so we...

There seem to be some real pytest failures associated with this PR. @calad0i, can you take a look?

Don't worry about the test_weight_writer.py

I am not sure if our pytest environment is functional. I can try running them again, but they may fail for infrastructure reasons

The `test_qkeras.py::test_qgru[Vivado]` failure we can ignore. For cnn_mnist, why does this error cause the failure? We mentioned about possibly removing that test, but I want to understand why it's failing....

Let's add the fix to the test and maybe merge this? I think making auto a default for some layer types could be a different PR, and I think it's...