Jovan Mitrevski

Another option, maybe better, is to split the fifo depth optimization into two optimizers, and not have the optimizer call write explicitly. Instead, the write can be explicitly scheduled in...

I have no problem putting the `+ writer_pass` bask. That's less effort than splitting the flow into multiple optimizers, though it does require #641 to function in all cases. Splitting...

I put back the `+ writer_pass`, and made the corresponding change in vivaldo_accelerator. So provided the tests are good, this should be fine to accept (along with #641), but if...

@vloncar, I was curious if you have any thoughts about how the FIFO depth optmization starts the writer flow external to the main flow. Should it be updated to just...

I think this is a fairly minor big fix: basically making the fifo depth optimization depend on `vivado:ip` and not the writer. It is more of an optimization since it...

There is a change in the fifo depth optimization discussed in in in #642, basically getting rid of the explict, out of flow write called from the optimizer, that would...

I think this change should go in since it fixes the current fifo depth optimization, and even if we change how we do the optimization, this will have no ill...

Any more thoughts on this? I have to tell people to use it if they are doing fifo depth optimization, which is a bit annoying.

pytest.activations is failing: ``` E AssertionError: E Not equal to tolerance rtol=0.02, atol=0.02 E E Mismatched elements: 8000 / 8000 (100%) E Max absolute difference: 1.12238881 E Max relative difference:...

It generally looks good to me so I approved it. I sort of wanted to trigger the pytests again, but couldn't figure out how.