Jovan Mitrevski comments

Results 133 comments of


                                            Jovan Mitrevski

Problem tracing binary CNN model after recent tracing optimization

I am including @AdrianAlan and @jmduarte because they were involved in the latest tracing updates.

Problem tracing binary CNN model after recent tracing optimization

I am not sure it's a complete fix. When I attempted the fairly straightforward fix of checking that it's not None, I ran into isuses when activation was a string.

Problem tracing binary CNN model after recent tracing optimization

We should validate the fix on this, as well.

Problem tracing binary CNN model after recent tracing optimization

Maybe it does fix it. I just checked out the PR, and I get no error. I thought that it complained about a string activation having `__name__` extracted, but I...

Problem tracing binary CNN model after recent tracing optimization

This has been fixed with the merge of #987 (which replaced #961)

Generalize pooling accumulator inference

> Do we need a corresponding fix for Quartus? > > https://github.com/fastmachinelearning/hls4ml/blob/f41951c57883022362dd4ffbe6ce3ed4efe36811/hls4ml/templates/quartus/firmware/nnet_utils/nnet_pooling.h#L38-L74 Actually I think it also needs to be done for vitis (which has its own implementation) in addition...