Jovan Mitrevski

Results 133 comments of Jovan Mitrevski

We can fix the failing `test_cnn_mnist.py` with: ``` (fastml310) jovans-mac:pytest jmitrevs$ git diff diff --git a/test/pytest/test_cnn_mnist.py b/test/pytest/test_cnn_mnist.py index ab3365f2..a8b77862 100644 --- a/test/pytest/test_cnn_mnist.py +++ b/test/pytest/test_cnn_mnist.py @@ -70,6 +70,8 @@ def test_mnist_cnn(keras_model,...

Based on our meeting, we have the following action items: 1. In backends/catapult/passes, remove any passes that are not used. 2. Also in backends/catapult/passes, note passes that are used but...

Can this work inside a jupyter notebook?

Clang doesn't seem to like this ``` (fastml39) Jovans-Mac:hls4mlprj_auto_conv2d_Quartus_io_stream jmitrevs$ bash build_lib.sh In file included from firmware/myproject.cpp:2: In file included from firmware/parameters.h:11: firmware/nnet_utils/nnet_conv2d_stream.h:135:5: error: no matching function for call to...

The issue seems to be that this: ```python model.add(Conv2D(4, kernel_size=(1, 1), activation='relu', name='last_layer')) # Will become PointwiseConv2D ``` doesn't actually become PointwiseConv2D for Quartus. The bug it uncovered seems tangential...

> is this the same issue that was observed in #878? I believe so. If you have a filter of size 1, then things like `line_buffer[CONFIG_T::filt_height - 1][CONFIG_T::n_chan]` wind up...

I made [vloncar #53](https://github.com/vloncar/hls4ml/pull/53) into your branch with changes for dense and standard convolution. Let me know what you think. If you like the way I made this, I can...

We merged part 1. Should we merge part 2?

The pytest error is unrelated to the PR so from my side this can be merged. I'll let Vladimir give the last OK.

This was motivated by issue #957