Jérémie Bresson

Results 261 comments of Jérémie Bresson

Project remote mirrors API is: https://github.com/gitlab4j/gitlab4j-api/blob/8259f86f881ec7408aabf569c567c23494f1b03d/gitlab4j-api/src/main/java/org/gitlab4j/api/ProjectApi.java#L4382-L4428 Indeed the pull mirror API https://docs.gitlab.com/ee/api/project_pull_mirroring.html can be contributed to this project

Indeed if the endpoint is paginated, we need to adjust the client lib. Feel free to provide a pull request, I am happy to have a look.

I was checking [`PersonalAccessTokenApi`](https://github.com/gitlab4j/gitlab4j-api/blob/main/gitlab4j-api/src/main/java/org/gitlab4j/api/PersonalAccessTokenApi.java) but this seems to be something else. A PR is welcomed for this addition.

Also I don't know if the error message SRGQLDC035010 is used somewhere else, but it would be better to say: > Cannot instantiate `WorkItemWidgetEmailParticipants` (not defined as sub-type of `WorkItemWidget`)...

The fix is simple for this error is simple. For my example project: https://github.com/jmini/gitlab-experiments/commit/7a4edce7cb3e530983054cebd66508bf294ee468

> We could theoretically ignore unknown subtypes, but it doesn't sound very safe to me, it could lead to unexpected issues, for example, if the user wrongly declares the name...

> So I think it would be better (for the world, not necessarily for you at this moment ;-), if the API would allow that type of filtering on the...

I am not yet really familiar with the code base. I would need some pointers: 1. can the signature of `io.smallrye.graphql.client.impl.typesafe.reflection.TypeInfo.subtype(String)` be changed to `Optional` 2. where are you defining...

At the end, my current thinking is that the reason for this issue is a limitation in *jsonb*. https://github.com/jakartaee/jsonb-api/issues/368 With jackson it would be possible to deserialize the GraphQL result....

> if the API would allow that type of filtering on the widgets field... something like `widgets(typeFilter: ["WorkItemWidgetLabels", "WorkItemWidgetLinkedItems"])`. I think GitLab has made the same observation. The `widgets` fields...