Jeff Hodges

Results 86 comments of Jeff Hodges
trafficstars

Could you give me a full example? I wrote a test that seems to pass my understanding of this ticket. It's in this PR. https://github.com/jmhodges/copyfighter/pull/10 The important bit is the...

Hm, it was passing locally. Fixing it up.

yeah, that test doesn't pass even before that commit, though?

Yeah, those are a good start! The "non-additive" is maybe not super clear to folks, but it's definitely the flavor of what I was looking for.

It doesn't seem that anything in gazelle is actually using `golang.org/x/oauth2`? I did [a search on GitHub](https://github.com/search?q=repo%3Abazelbuild%2Fbazel-gazelle%20oauth2&type=code) (and local grep) and couldn't find any. Maybe it can just be dropped?...

I think this might be a generic problem with any CBOR to JSON conversion. For instance, CBOR allows for non-string keys in its maps and JSON libraries typically don't (because...

Well! The `DefaultMapType` config definitely fixed the original issue here! [Pushed to my branch](https://github.com/jmhodges/indigo/tree/jeff.hodges/gosky-cbor-json). I'm not sure if there's other types where this would fail because I'm less familiar with...

Thank you and sorry! I think you want to make this change against the version of this that's in the [extras directory](https://github.com/bazelbuild/rules_go/tree/master/extras) of rules_go. The rules_go folks decided they wanted...

Dropped a mention on the PR but: Thank you and sorry! I think you want to make this change against the version of this that's in the [extras directory](https://github.com/bazelbuild/rules_go/tree/master/extras) of...