James Blair

Results 310 comments of James Blair

Discussed during sig-etcd triage meeting. We recently put work into updating `etcd-io/website` to put a proper markdown linting workflow in place. I am supportive of adding a new prow presubmit...

> @jmhbnz, could this be a bug? @thedtripp is already part of our org 🤔 > > Edit: I think it's because he doesn't belong to any teams. Should he...

Discussed during sig-etcd triage meeting. There are a number of modules that need updating, so we could break this up into smaller chunks and do it one module at a...

Just curious - we should compare the `make verify` runtime before enabling these checks and now to make sure we aren't increasing test runtimes too significantly. @mmorel-35 - As you...

Hey @Shubhdeep02 - Please rebase and squash commits, there should only be a single commit for this pull request, thanks.

> Hey @jmhbnz i have rebased the commits please take a look into it. Thanks - there are still three commits showing, please squash your commits.

> @jmhbnz I guess they aren't part of the changed file but some self generated version update file. So should they be squashed? Hi @Shubhdeep02 - Please rebase to resolve...

Discussed during sig-etcd triage meeting, @ahrtr could you please take a look at this pr and provide some guidance on next steps, thanks!

Discussed during sig-etcd triage meeting, it looks like we don't have consensus to proceed with the code change and a docs change would be a safer way forward. Closing in...