Jonathan M Davis comments

Results 57 comments of


                                            Jonathan M Davis

Fix dlang#10798 — Reimplement FFT solver to support `@nogc nothrow pure @safe`

Honestly, this is not code or an algorithm that I'm particularly familiar with. So, I'm not necessarily well-suited to review it (and I don't know who would be out of...

std/path: make globMatch work with @nogc

> Calling a function allocates memory (on the stack). > > I think you would need to define what "allocate memory" means more precisely before beginning to discuss whether `@nogc`...

`std.uni.icmp` does not compare `ß` or `ẞ` correctly aganist `SS`

> > e.g. GROß just looks strange. > > Nevertheless, it’s correct. AFAIK the traditional spelling — i.e. `GROSS` — is considered an alternative form only nowadays . Wikipedia claims...

`std.uni.icmp` does not compare `ß` or `ẞ` correctly aganist `SS`

> We don't need to figure out what to do here. What Unicode says goes. > > The moment we go against the experts on the subject and create our...

Nullable's `toHash` needs to infer its attributes

Actually, looking at this deeper. There are two issues here. 1. `Nullable`'s `toHash` should be inferring its attributes. There is no guarantee that `toHash` on the type contained by `Nullable`...

Nullable's `toHash` needs to infer its attributes

And actually, `const` can't be inferred, so in addition to making it so that the attributes are inferred, we'll need to check in a `static if` whether `hashOf` works on...

Nullable's `toHash` needs to infer its attributes

Well, I haven't fully figured out the situation here, but it's worse than I thought. Unfortunately, `TypeInfo` is still a thing, and AAs still use it, and it's really not...