neoism
neoism copied to clipboard
Added support for https connections
Added support for https connections with either skipping the cert check or passing the cert file in an env variable.
This is especially useful as from neo4j 2.2 as the default is to run over https.
Unfortunately the Go https implementation does not accept the neo4j cert file that is automatically generated during the neo4j installation so you still have to create a key and cert file manually.
Thanks for contributing! Please add a unit test to cover the new functionality, then I will be happy to merge the PR.
Sure, how would you suggest to do this?
When I set the version number to 2.2+ I expect the start-neo4j.sh script to run neo4j by default over https. Do you want to run all the existing test over https from now on? Better may be to test both http and https but this would imply installing two instances side by side or switching from one to the other at some point.
Ideally there should be a test that creates a self signed key and certificate to test out the https connection where the client passes a certificate (so not skipping the cert check).
Any movement on this?
I've created a PR to allow passing in a http.Client. That would also allow you to achieve what you want here by creating your own http.Client outside of neoism.
https://github.com/jmcvetta/neoism/pull/97