neoism icon indicating copy to clipboard operation
neoism copied to clipboard

#94 - Rename benchmark_test_* files

Open co0p opened this issue 7 years ago • 1 comments

Importing the testing package in a file, which is used by the main binary, will pollute the flags package with testing help usage messages. This hinders the usage of the neoism package in a cli application. The file benchmark_test*.go are loading the testing package and are therefore responsible for the flag pollution. To exclude the benchmark_connect helpers one can suffix the files with _test. This will ensure that the benchmark_connect helpers are only loaded during testing and do not pollute the main binary. Another solution would be to introduce a neoism_test package, which would result a massive code reorganization.

co0p avatar Feb 25 '18 18:02 co0p

Codecov Report

Merging #110 into develop will increase coverage by 0.35%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #110      +/-   ##
===========================================
+ Coverage    72.93%   73.28%   +0.35%     
===========================================
  Files           15       14       -1     
  Lines          798      786      -12     
===========================================
- Hits           582      576       -6     
+ Misses         128      122       -6     
  Partials        88       88
Impacted Files Coverage Δ
node.go 74.25% <0%> (-0.9%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ffb5c6...0db20f8. Read the comment docs.

codecov[bot] avatar Feb 25 '18 18:02 codecov[bot]