testing-nestjs icon indicating copy to clipboard operation
testing-nestjs copied to clipboard

wip(mongo-sample): rearrange sample - add in-memory for e2e, mockingbird and dto's

Open omermorad opened this issue 4 years ago • 5 comments

The purpose of this pull request is to put some order in the "cat" entity. I reorganized the entities: interface, DTO and turned the Mongoose Schema into a class (using nestjs mongoose decorators).

Other than that I plan to add an e2e test containing a mongo-in-memory connection and use the Mockingbird library to create some fixtures.

omermorad avatar Feb 13 '21 08:02 omermorad

Lots of changes I'm seeing! Most of them good. Can we stay away from the feature/service/feature.service directory structure though, and keep it as feature/feature.service the way it was?

jmcdo29 avatar Feb 13 '21 18:02 jmcdo29

Haha yes, a lot of changes.

Thanks! And yes, sure, I will change the structure accordingly :)

omermorad avatar Feb 13 '21 18:02 omermorad

@jmcdo29 I'm still working on the example, I had a rough week :/ Also - I'm planning to change the Mockingbird package API, can we wait with this a bit? I really want to enrich this example!

omermorad avatar Feb 19 '21 17:02 omermorad

@jmcdo29 I'm still working on the example, I had a rough week :/ Also - I'm planning to change the Mockingbird package API, can we wait with this a bit? I really want to enrich this example!

Sure. Feel free to keep this open and work when you can or just close it out and create a new PR.

jmcdo29 avatar Feb 19 '21 17:02 jmcdo29

I will keep this one open 🙏🏼 I will update it soon as I can

omermorad avatar Feb 19 '21 18:02 omermorad