nest-commander icon indicating copy to clipboard operation
nest-commander copied to clipboard

refactor: change split args string

Open fjodor-rybakov opened this issue 3 years ago • 3 comments

At the moment, it is not possible to make a space in the name of the command argument. This pull request fixes this issue.

fjodor-rybakov avatar Feb 09 '22 13:02 fjodor-rybakov

☁️ Nx Cloud Report

CI ran the following commands for commit 67443c9f120aa2250fa7c74298207656a22002b4. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Feb 09 '22 13:02 nx-cloud[bot]

⚠️ No Changeset found

Latest commit: 67443c9f120aa2250fa7c74298207656a22002b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 09 '22 13:02 changeset-bot[bot]

it is not possible to make a space in the name of the command argument.

Does commander itself support that by default? Huh, TIL. Could you add to the integration tests to show that this provides the expected functionality? And after that, can you run the changeset wizard to make a patch change for this? Thank you

jmcdo29 avatar Feb 09 '22 15:02 jmcdo29