crypt_keeper icon indicating copy to clipboard operation
crypt_keeper copied to clipboard

Upgrade for Rails 7.1

Open simpl1g opened this issue 2 years ago • 9 comments

I updated public/private keys, I'm not sure why they stopped working, maybe they expired. So I generated new with 50 years expiration.

simpl1g avatar Apr 18 '24 19:04 simpl1g

@jmazzi Hi, sorry to bother you, any chances to review and release new version of gem? Tests are passing locally

simpl1g avatar May 08 '24 17:05 simpl1g

@jmazzi could you merge it if it looks good for you

khrvi avatar Jun 04 '24 12:06 khrvi

@jmazzi please release the Rails 7.0.x gem version (right now only works with Rails 7 but not for 7.0.x) before this Rails 7.1 gem version

ByteDecoder avatar Jun 05 '24 18:06 ByteDecoder

This MR will support all 7.x versions. Is this desired that it will already support the upcoming Rails 7.2 release?

johan-smits avatar Jun 06 '24 07:06 johan-smits

@johan-smits thanks, makes sense, downgraded dependency to exclude 7.2

simpl1g avatar Jun 08 '24 12:06 simpl1g

Bernie Sanders sitting in a foldable chair

@jmazzi bumping this now that it's idled for a few months 🙏 any chance you could review please?

tkling avatar Sep 12 '24 20:09 tkling

Also prepared PR for Rails 7.2 https://github.com/simpl1g/crypt_keeper/pull/2

simpl1g avatar Sep 16 '24 15:09 simpl1g

@simpl1g do you have permission to merge this branch?

ByteDecoder avatar Jul 29 '25 22:07 ByteDecoder

@simpl1g do you have permission to merge this branch?

Sorry, I don't have such permission, I would love to merge this :)

simpl1g avatar Jul 30 '25 07:07 simpl1g