better-font-finder icon indicating copy to clipboard operation
better-font-finder copied to clipboard

Can I do fork and add filter by language support?

Open jardicc opened this issue 8 years ago • 3 comments

Can I do fork and add filter by language support?

Maybe I could add some tooltips with text labels? I have no Idea what which icon means. And make visual difference between radio-button and checkbox-button behavior would be also nice. :-)

jardicc avatar May 29 '17 22:05 jardicc

You don't need my permission to fork. It's an MIT license. Do what you like, and have fun!

jmattthew avatar May 30 '17 01:05 jmattthew

I just want know if I could do pull request. Or if you should put this on my own site.

jardicc avatar May 30 '17 07:05 jardicc

I recommend that you use your own site. The reason is that, right now, I don't have time to review any new code in order to consider merges. I'd feel bad if your efforts sat around unmerged. Also, I'd feel really bad if I decided not to merge something you created.

For now, I've decided against adding any written tooltips because this thing is an experiment in explaining with images instead of text and to let people have the feeling of discovery when they tap a button and see what happens.

On Tue, May 30, 2017 at 12:19 AM, jardicc [email protected] wrote:

I just want know if I could do pull request. Or if you should put this on my own site.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jmattthew/better-font-finder/issues/1#issuecomment-304795182, or mute the thread https://github.com/notifications/unsubscribe-auth/ADSvDud4Cpx12UkaywROnfoTfBef7KTgks5r-8LygaJpZM4NprE1 .

jmattthew avatar May 31 '17 22:05 jmattthew