elodie icon indicating copy to clipboard operation
elodie copied to clipboard
verified publisher icon jmathai

Optimize location lookup, avoid repeated config reads

Open adamcandy opened this issue 5 years ago • 3 comments

This caches the false states of 'prefer_english_names', which I expect is what was intended. Fixes #371 (Geolocation examines config.ini for every new lookup).

adamcandy avatar Apr 20 '20 15:04 adamcandy

Coverage Status

Coverage decreased (-0.2%) to 90.877% when pulling aa023697d7246cb8e057ee637b9e44942dc2babb on adamcandy:prefer-english-names-optimize into 8e95b96e111ef1e892716a17aecfc9095fb52a90 on jmathai:master.

coveralls avatar Apr 20 '20 16:04 coveralls

This looks good. Can you cherry pick the commits from #370 into this branch so we can combine them into a single PR?

jmathai avatar Apr 22 '20 06:04 jmathai