elodie icon indicating copy to clipboard operation
elodie copied to clipboard

Published 20 hours ago • verified publisher icon jmathai

Prefer English names logic is broken

Open adamcandy opened this issue 4 years ago • 3 comments

bool cannot be used to test for a True or False string in python.

In elodie/geolocation.py:

__PREFER_ENGLISH_NAMES__ = bool(config['MapQuest']['prefer_english_names'])

will evaluate to True for any string specified!

adamcandy avatar Apr 20 '20 14:04 adamcandy

Fixed in PR 370.

adamcandy avatar Apr 20 '20 15:04 adamcandy

Hi, is this bug related to the config prefer_english_names=False ? Because I set it in the config.ini but the locations names are still cerated in English.

crishnakh avatar Nov 01 '20 19:11 crishnakh

Yes @crishnakh exactly. The fix in PR 370 sorts all the problems I had with this option, so give this a try. I should get around to merging this change in together with some others. I think @jmathai wanted me to combine the PRs rather than pull in individually.

adamcandy avatar Nov 05 '20 19:11 adamcandy

The new MapQuest API no longer supports this functionality. Have opened #425 to track it but will probably just mark the capability as deprecated.

jmathai avatar Nov 18 '22 17:11 jmathai