elodie
elodie copied to clipboard
adding translation of datetime and location names
I'm not english, therefore prefer_english_names
dont help me, but I wanted to get location and datetime (month name) in danish.
I said this in my other PR aswell: Im no python developer so please let me know if this is the wrong way to do things
Im sorry. I dont get this testing in python apparently.. 😢
Coverage increased (+0.07%) to 90.711% when pulling a72e542e409dffa6d8a17c8b7fe6fffb3f153c11 on tcarlsen:translation into b07d26c38940990b5027b7b7410d6bbcc2e63ab3 on jmathai:master.
okay why is this faling??
test_lookup_with_prefer_language_danish
1983 assert res['address']['city'] == 'K\xf8benhavn', res
1984AssertionError: {u'display_name': u'18G, Vestergade, K\xf8dbyen, Vesterbro, K\xf8benhavn, K\xf8benhavns Kommune, Region Hovedstaden, 1456, Danmark', u'place_id': u'1675725', u'lon': u'12.568567', u'boundingbox': [u'55.677547', u'55.677747', u'12.568467', u'12.568667'], u'osm_type': u'node', u'licence': u'Data \xa9 OpenStreetMap contributors, ODbL 1.0. https://osm.org/copyright', u'osm_id': u'340565033', u'lat': u'55.677647', u'address': {u'city': u'K\xf8benhavn', u'house_number': u'18G', u'country': u'Danmark', u'county': u'K\xf8benhavns Kommune', u'suburb': u'Vesterbro', u'state': u'Region Hovedstaden', u'road': u'Vestergade', u'country_code': u'dk', u'neighbourhood': u'K\xf8dbyen', u'postcode': u'1456'}}
I test for address city to be "K\xf8benhavn" and the result is "K\xf8benhavn".... why is that a failed test?
only python 2.7 is failing now.. not sure how to fix... sorry all the spam commits
been a year. any1 wanna help me fix the last error so this translation pr can be part of master? @jmathai