elodie icon indicating copy to clipboard operation
elodie copied to clipboard

Add file extension to custom path part

Open SiggiSmara opened this issue 6 years ago • 4 comments

First, thanks for your effort in creating this project! I had halfway started something similar on my own some time ago and abandoned it due to time constraints. What you have done here is way more advanced than what I had accomplished before giving up.

The pull request addresses #271 at least the extension part. I wasn't interested in going further than that but I also felt sad that this IMHO very useful enhancement didn't result in a pull request at the end of it so here it is.

I can also verify that it works as indicated.

EDIT: Btw, I'm more than happy adding a test for this but I wasn't sure if/where/how you are testing for such things. If you point me in the right direction then I can add that to the pull request.

SiggiSmara avatar Nov 16 '19 15:11 SiggiSmara

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 16 '19 15:11 CLAassistant

Thanks for the PR. Looks good to me. Before merging it would be great to have a unit test that verifies this functionality so we don't break it in the future.

Let me know if that's not something you feel comfortable doing.

jmathai avatar Nov 18 '19 07:11 jmathai

Sorry for the late reply. I'm more than happy to add some unit test for it. Can you point me to the file that does the test for the other parameters in that function? I think it would make sense to have them all in one place, but I don't know the code base well enough.

SiggiSmara avatar Nov 21 '19 14:11 SiggiSmara

Thanks. Here is an example.

jmathai avatar Nov 21 '19 17:11 jmathai