elodie icon indicating copy to clipboard operation
elodie copied to clipboard

GooglePhotos plugin duplicates photos when using the update command

Open jmathai opened this issue 6 years ago • 3 comments

When using the update command with elodie.py the GooglePhotos plugin will upload the same photo again causing duplicates in the Google Photos library.

jmathai avatar Aug 21 '19 20:08 jmathai

Is this something that's been an issue for a while? Would like to pick this up.

Any gut feelings on how to go about a solution?

bmitchinson avatar Aug 24 '19 13:08 bmitchinson

This has been an issue since the plugin was first created a few weeks ago.

The command sent to elodie somehow needs to be made available to the plugin so that it can decide what to do on import vs update. I don't believe this context is passed from elodie.py into filesystem.process_file at the moment nor is it accessible in other ways. Ideas welcome :).

jmathai avatar Aug 24 '19 17:08 jmathai

It does look like we pass move=False for import [1] and move=True [2] for update but I'm not sure if this is the right value to rely on.

[1] https://github.com/jmathai/elodie/blob/master/elodie.py#L65 [2] https://github.com/jmathai/elodie/blob/master/elodie.py#L322

jmathai avatar Aug 24 '19 17:08 jmathai