elodie icon indicating copy to clipboard operation
elodie copied to clipboard

[Suggestion] Include My Dockerfile

Open ps1337 opened this issue 7 years ago • 1 comments

Hello and first of all thanks for maintaining this great project.

I've seen this repository includes its own Dockerfile, which is good for most cases. However, I (personally) thought some things can be improved. That's why I created my own dockerized version of elodie with these additional benefits:

  • Elodie doesn't run as root, it runs as own unprivileged elodie user inside the container. This has been implemented for security reasons and to allow sharing the UID between the user on the host and the user inside of the container. This prevents files from being not accessible without using chown first.

  • Based on alpine and therefore smaller and cleaner. The version of exiftool is > 10.20 too by default.

  • Included Makefile for additional convenience, e.g. when running the container.

Let me know what you think - maybe we can merge both Dockerfiles if you want to stay on debian :)

ps1337 avatar Jul 18 '18 19:07 ps1337

I don't have a huge opinion on this. Though staying on debian seems to be a safe bet :). Mind submitting a PR with a merged Dockerfile?

jmathai avatar Oct 25 '18 21:10 jmathai