jmathai
--trash deletes image files with errors that are not copied
When using elodie with the --trash handle and encountering images that could not be properly handled and result in errors, elodie deletes them anyway from the source folder.
This should not be the default behaviour. I would expect elodie to leave them in the folder, so I can manually inspect them and fix the problem.
This could prove problematic in the long run, since I tend to periodically delete images and videos on my smartphone, thinking they are all safely backed up.
Thanks @baffo. I've labeled this as a bug. I can't think of any circumstances under which Elodie should delete a file it can't properly process.
Hi @baffo,
What was/is the file type you're dealing with?
Also can you define "not be properly handled"?
For example 3GP[p] files aren't recognised/supported so they are left in my source folder. Inspecting the 3GP file with exiftool[l] shows it has neither of the following tags:
Date/Time Original : 2016:01:17 12:22:04
Create Date : 2016:01:17 12:22:04
--
@jmathai here's my 3GP Exif[z] - can you tell me why it's unrecognised/unsupported by elodie?
Hope to hear back
Cheers
[l] https://sno.phy.queensu.ca/~phil/exiftool/ [p] https://en.wikipedia.org/wiki/3GP_and_3G2 [z]
ExifTool Version Number : 11.01
File Name : 2018-09-07_23-48-37-video0003 (2).3gp
Directory : /Volumes/synology/gtd/home/reference/image/2010-09-11 - EVENT Wedding with Lina & Tom Lane et al/Unknown camera make/Unknown camera model/Unknown Location
File Size : 2.1 MB
File Modification Date/Time : 2018:09:08 04:08:16+02:00
File Access Date/Time : 2018:09:08 04:08:16+02:00
File Inode Change Date/Time : 2018:09:08 04:08:16+02:00
File Permissions : rw-rw-rw-
File Type : 3GP
File Type Extension : 3gp
MIME Type : video/3gpp
Major Brand : 3GPP Media (.3GP) Release 4
Minor Version : 0.3.0
Compatible Brands : 3gp4, mp41, 3gp6
Movie Data Size : 16
Movie Data Offset : 2149009
Movie Header Version : 0
Create Date : 0000:00:00 00:00:00
Modify Date : 0000:00:00 00:00:00
Time Scale : 1000
Duration : 21.31 s
Preferred Rate : 1
Preferred Volume : 100.00%
Preview Time : 0 s
Preview Duration : 0 s
Poster Time : 0 s
Selection Time : 0 s
Selection Duration : 0 s
Current Time : 0 s
Next Track ID : 5
Copyright :
Author :
Title :
Description :
Performer :
Genre :
Rating : Entity= Criteria=
Classification : Entity= Index=0
Keywords :
Location Information : (none) Role=shooting Lat=0.00000 Lon=0.00000 Alt=0.00 Body= Notes=
Track Header Version : 0
Track Create Date : 0000:00:00 00:00:00
Track Modify Date : 0000:00:00 00:00:00
Track ID : 3
Track Duration : 21.31 s
Track Layer : 0
Track Volume : 0.00%
Image Width : 320
Image Height : 240
Graphics Mode : srcCopy
Op Color : 0 0 0
Compressor ID : mp4v
Source Image Width : 320
Source Image Height : 240
X Resolution : 72
Y Resolution : 72
Bit Depth : 24
Video Frame Rate : 19.149
Balance : 0
Audio Format : samr
Audio Channels : 2
Audio Bits Per Sample : 16
Audio Sample Rate : 8000
Encoder Vendor : pvmm
Encoder Version : 0
Matrix Structure : 1 0 0 0 1 0 0 0 1
Elementary Stream Track : 3 4
Media Header Version : 0
Media Create Date : 0000:00:00 00:00:00
Media Modify Date : 0000:00:00 00:00:00
Media Time Scale : 1000
Media Duration : 21.31 s
Handler Type : Object Descriptor
Handler Description : ODHandler
Other Format : mp4s
XMP Toolkit : Image::ExifTool 11.01
Original File Name : VIDEO0003 (2).3gp
Avg Bitrate : 807 kbps
GPS Altitude : 0 m
GPS Altitude Ref : Above Sea Level
GPS Latitude : 0 deg 0' 0.00" N
GPS Longitude : 0 deg 0' 0.00" E
Image Size : 320x240
Megapixels : 0.077
Rotation : 0
GPS Position : 0 deg 0' 0.00" N, 0 deg 0' 0.00" E
Hi @ldexterldesign, sorry for the late reply.
The filetypes I'm dealing with are jpg. I use elodie for sorting my photo library.
By "not properly handled" I mean photos that were either made with some old cellphone model and might not have all the proper exif data and photos that were altered in photoshop and exported as jpg images but might not have preserved their original exif data.
@baffo
Thanks for reply
I haven't experienced your issue (but if I have I'm probably oblivious to it)
From now on I will ensure I review errors in detail and inspect whether the files have been deleted or not. If they are deleted I will post them to this thread in future. If you're able can you do the same and hopefully we can resolve this.
If it exists, quite a serious bug IMO
Cheers
https://github.com/jmathai/elodie/issues/282#issuecomment-430880258 - related?
I also have this issue. if I do an import of a folder with the --trash option, once it finishes it lists number of successes and number of errors. if I run the exact same command again it says 0 success and 0 errors because it trashed all the files, even ones that didn't import
