Jan Martiska
Jan Martiska
Sorry, it's a bit tough to explain :D The point is that without these three booleans, it's not possible to tell whether the problem is that 1: somebody called one...
Yeah, and the point is to be able to throw an error message saying that "you tried to set two of them". So that, for example in Quarkus, we won't...
> @jmartisk do you mind adding a few test cases? Sure. Just a test that tries to set two of them and expects an error, or do you have something...
@langchain4j I've added a test :)
@langchain4j still have that problem somewhere? Got a stack trace? Doesn't look related to my PR, the test only verifies that you can't set more retrievers, but the test only...
@langchain4j Ah, yeah I see the error now. Will send PR in a few minutes! Sorry!
GraphQL & Kotlin: Schema Creator for Queries with Collections does not consider the NotNull/Nullable
Yeah using Jandex for deducing the nullability of Kotlin types is quite tricky because of how the Kotlin compiler stores the metadata all over the place. We've only recently added...
GraphQL & Kotlin: Schema Creator for Queries with Collections does not consider the NotNull/Nullable
Submit a PR please :)
You're turning "attempts" into "retries" here I'd say. If it's called 'attempts', shouldn't 0 mean an error (`IllegalArgumentException`), and 1 to attempt exactly once? That is, unless we rename the...
I would personally keep it as attempts, so 0 means error, and 1 means try exactly once. But it depends what @langchain4j thinks