Jan Martiska

Results 138 comments of Jan Martiska

SR Metrics itself does not support application-name tags right now, it would be up to the app server (WildFly etc) to provide it, but we haven't figured out how exactly...

Do we actually use it from multiple threads (for modification) somewhere? Because populating this map is a thing that happens at build time (startup time in JVM) by iterating through...

If we don't plan modifying this in multiple threads, then synchronizing comes with an unnecessary performance penalty, in which case I think we should just make it more clear (in...

Hey @theute + @pilhuhn , so I'd start with timers only for now and implement this in a way that SmallRye will have a `io.smallrye.metrics.annotation.Timed` annotation that does the same...

It would look like this - for annotated metrics you will use ``` @io.smallrye.metrics.annotation.Timed(histogramType=HistogramType.THRESHOLD_VALUES, buckets=[0.05, 0.1, 0.5]) // instead of @org.eclipse.microprofile.annotation.Timed public void timedMethod() { // your logic } ```...

Perhaps `COUNTS_WITHIN_BUCKETS` would be more understandable than `THRESHOLD_VALUES`, I don't know.

If there's really demand for something like what I described in comments https://github.com/smallrye/smallrye-metrics/issues/325#issuecomment-644575785 and https://github.com/smallrye/smallrye-metrics/issues/325#issuecomment-644733317 then I am willing to do that, I think it is realistic that it could...

Most likely, yes. We can have a new separate module within SmallRye Metrics that implements this, and the Quarkus-Micrometer extension will depend on it. Or we could move it to...