Jeff Malins

Results 18 comments of Jeff Malins

Note, the kernel recording tests needed to be disabled for the `getBinScriptCommand` method since the output is not deterministic due to the tarball extraction directory being different between runs. This...

@RomainMuller, are there any changes you'd recommend to this PR?

@RomainMuller that is a _profoundly_ better approach! 👍 How about this for an API, reusing the `InvokeScriptRequest` struct for the argument: ```typescript // api.ts export interface GetScriptCommandResponse { command: string;...

I realized after getting into the code, that JSII requires a unique argument type for each API call. PR #3794 uses the basic approach above, but with a `GetScriptCommandRequest` argument...

I encountered this as well. I worked around it by excluding all runtime Lambda code from the JSII build. Lambda code becomes part of CDK assets, rather than the JSII...

Hi @RomainMuller, Flaky tests aside (two Maven download failures in a row), please let me know what else you'd require to merge this PR. Thanks

Thanks, will do. I have a workaround for now, but expect one in the next few days.

An alternative workaround, if you need to keep the artifact format as a pure ZIP is used [here](https://github.com/projen/projen/pull/2132). The approach is to use the `getfacl` / `setfacl` CLI tools to...