hydrate-reminder icon indicating copy to clipboard operation
hydrate-reminder copied to clipboard

Add new animation types configuration setting

Open jmakhack opened this issue 1 year ago • 2 comments

Feature Reasoning

A new feature being introduced in v2.0.0 is the hydrate animation feature. Right now, there is only the option to enable/disable the animation setting. It would be nice to also have the ability to set which animation gets played on every hydrate interval.

Feature Description

Add a new configuration option Animation type which contains a dropdown of animation options. For a temporary second option, AnimationID.COOKING_WINE can be used for now.

For this feature, it would be good to create a new enum HydrateReminderAnimations similar to HydrateReminderTimerImages as well. Other new classes may need to be created as well such as a handler/provider class.

Additional Context

Please refer to CONTRIBUTING.md for info on how to setup, build, run, and test this project.

jmakhack avatar Oct 10 '22 08:10 jmakhack

can I work on this? and can you tell which do I need to add all this? HydrateReminderConfig.java? and the enum for hydrateReminderTimerImages doesn't exists. I couldn't find it.

ArshErgon avatar Oct 16 '22 09:10 ArshErgon

@ArshErgon go for it! The timer images enum got recently refactored into the images package. The end result of this feature work should be a new dropdown option in the Animation settings section. It should be similar to the timer images dropdown but for animations instead of images.

jmakhack avatar Oct 16 '22 11:10 jmakhack