Error while installing on mac via Homebrew

[abhi18av]

Hi @jmacdonald ,

Thanks for the wonderful project - I'm really looking forward to using amp for teaching someone vim without all the config stuff.

I tried installing amp via brew but it fails to build. Unfortunately, I'm not familiar with rust so I don't quite understand what's wrong here.

(base) Abhinavs-MacBook-Pro:~ eklavya$ brew tap jmacdonald/amp && brew install amp
==> Tapping jmacdonald/amp
Cloning into '/usr/local/Homebrew/Library/Taps/jmacdonald/homebrew-amp'...
remote: Enumerating objects: 39, done.
remote: Total 39 (delta 0), reused 0 (delta 0), pack-reused 39
Unpacking objects: 100% (39/39), 4.34 KiB | 96.00 KiB/s, done.
Tapped 1 formula (64 files, 36.5KB).
Updating Homebrew...
==> Installing amp from jmacdonald/amp
==> Installing dependencies for jmacdonald/amp/amp: pkg-config, rust and cmake
==> Installing jmacdonald/amp/amp dependency: pkg-config
==> Downloading https://homebrew.bintray.com/bottles/pkg-config-0.29.2_3.mojave.bottle.tar.gz
==> Downloading from https://akamai.bintray.com/0d/0d14b797dba0e0ab595c9afba8ab7ef9c901b60b4f806b36580ef95ebb370232?__gda__=exp=1587709440~hmac=4267ed3291f672213866bd3cedbb6aae63d6b9977d5be4495f715ed58bfd7985&response-content-disposition=at
######################################################################## 100.0%
==> Pouring pkg-config-0.29.2_3.mojave.bottle.tar.gz
🍺  /usr/local/Cellar/pkg-config/0.29.2_3: 11 files, 623.6KB
==> Installing jmacdonald/amp/amp dependency: rust
==> Downloading https://homebrew.bintray.com/bottles/rust-1.42.0.mojave.bottle.tar.gz
==> Downloading from https://akamai.bintray.com/06/064407ccb9e4f033c998db2637c6ede24b7696d660cbefb7ad1e8e903a880960?__gda__=exp=1587709444~hmac=d38869c88c4e4ac1083a0dd9a06768242065b3175e13f1eeccd2c0441443bac0&response-content-disposition=at
######################################################################## 100.0%
==> Pouring rust-1.42.0.mojave.bottle.tar.gz
🍺  /usr/local/Cellar/rust/1.42.0: 20,487 files, 522.9MB
==> Installing jmacdonald/amp/amp dependency: cmake
==> Downloading https://homebrew.bintray.com/bottles/cmake-3.17.1.mojave.bottle.tar.gz
==> Downloading from https://akamai.bintray.com/c6/c62e8f5a02515337214c49807f55c47f4339a9afd8b2d62d6ab4450d03f2c689?__gda__=exp=1587709589~hmac=39fbd3122f35b0f9faf8a72ba6872bf02e699a6ad5ea6347c23d11ad68e6ad7c&response-content-disposition=at
######################################################################## 100.0%
==> Pouring cmake-3.17.1.mojave.bottle.tar.gz
==> Caveats
Emacs Lisp files have been installed to:
  /usr/local/share/emacs/site-lisp/cmake
==> Summary
🍺  /usr/local/Cellar/cmake/3.17.1: 6,156 files, 58.1MB
==> Installing jmacdonald/amp/amp
==> Downloading https://github.com/jmacdonald/amp/archive/0.6.0.tar.gz
==> Downloading from https://codeload.github.com/jmacdonald/amp/tar.gz/0.6.0
######################################################################## 100.0%
==> cargo build --release
Last 15 lines from /Users/eklavya/Library/Logs/Homebrew/amp/01.cargo:
    |
259 | impl<'a> Target for ::UrlQuery<'a> {
    |      -- lifetime `'a` defined here
260 |     fn as_mut_string(&mut self) -> &mut String { &mut self.url.serialization }
261 |     fn finish(self) -> &'a mut ::Url { self.url }
    |                                        ^^^^^^^^ - here, drop of `self` needs exclusive access to `*self.url`, because the type `UrlQuery<'_>` implements the `Drop` trait
    |                                        |
    |                                        returning this value requires that `*self.url` is borrowed for `'a`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0713`.
error: could not compile `url`.
warning: build failed, waiting for other jobs to finish...
error: build failed

If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
  https://github.com/jmacdonald/homebrew-amp/issues

These open issues may also help:
amp 5.2.0 https://github.com/jmacdonald/homebrew-amp/pull/3

Could you please help me out?

[dontlaugh]

When using the brew tap, I just hit this error, too. I have a working rust installation, so installing with cargo worked for me.

[abhi18av]

Correct me if I'm wrong, brew installs rust first and then tries to build it - with cargo by default right?

[jmacdonald]

@abhi18av yep, that's the gist! Apologies that it's taken so long for me to get back to you on this. It does look like you're building version 0.6.0, and it's likely it's no longer compatible with the latest version of Rust. That's my fault; I don't use MacOS anymore and haven't updated the homebrew formula.

I've just bumped it to use 0.6.2. Can you give that a shot and let me know if that resolves it for you?

[skyfaller]

The latest version 0.6.2 seems to work for me with Homebrew 2.3.0 on macOS Catalina 10.15.5.

[abhi18av]

Yes, I can confirm as well. Thanks for taking out the time for this @jmacdonald ! 🎉