Jared Lumpe

Results 52 comments of Jared Lumpe

@roland-KA what exactly is your use case for the `AbstractTree` type? I'm not familiar with `DecisionTrees.jl`, but I imagine that a decision tree has to define some additional attributes/methods besides...

I think a good question would be - how would this type even be used within the package? Besides defining `AbstractTree` and having our existing types inherit from it, I'm...

This is definitely something I've thought about, and my first idea was also the `Leaf` wrapper type. To expand on that I think there could be more wrapper types that...

Can either of you tell me what the expected return value of `treemap` is in this case? I'm a contributor but not the author of this code, and honestly I...

The parent API hasn't really been strictly defined yet, so I agree that `Base.parent` shouldn't be used for getting the parent of a node. I plan to submit a PR...

I had filed a PR (#86) to resolve this problem. It defines a `DictChildren` type which behaves identically to the wrapped `AbstractDict` with regard to `getindex()`, `keys()`, `values()`, and `pairs()`,...

The `pairs` solution works for `getdescendant` and printing, but I definitely think that this is not at all what most people would expect if they are trying to work with...

@oscardssmith Any thoughts on this?

This is actually less being broken than just the docstrings for these functions not existing. I added those functions to the API page to highlight the issue, but so far...

Did this ever end up getting implemented?