free-disk-space icon indicating copy to clipboard operation
free-disk-space copied to clipboard

Suggestion: default `swap-storage` to `false`

Open zaikunzhang opened this issue 1 year ago • 0 comments

Hello @jlumbroso ,

First of all, thank you for this fantastic action. It is vital in the development of my project PRIMA.

README mentions the following.

        # all of these default to true, but feel free to set to
        # "false" if necessary for your workflow
        android: true
        dotnet: true
        haskell: true
        large-packages: true
        docker-images: true
        swap-storage: true

I suggest defaulting swap-storage: true to false. Otherwise, some memory-consuming actions may get the runner shut down due to memory starvation --- it is not uncommon for a space-intensive action to be memory-hungry as well. This did happen in PRIMA, and it took a couple of days to figure out that swap-storage: true was the reason.

If swap-storage: true is going to be retained, then careful documentation may be necessary to highlight the above-mentioned caveat.

Many thanks!

Best regards, Zaikun

zaikunzhang avatar Sep 10 '23 18:09 zaikunzhang